Data Stores: Migrate Analyzer store to `createReduxStore()` #74414

tyxla · 2023-03-14T13:10:52Z

Proposed Changes

This PR migrates the Analyzer store to use createReduxStore() and register() instead of registerStore().

Part of #74399. A follow-up to #73890.

Testing Instructions

The only step that uses this store is not currently enabled, so we have to manually enable it with a feature flag.
Navigate to /setup/site-setup/importLight?siteSlug=YOURSITE&flags=onboarding/import-light where YOURSITE is the slug of one of your sites.
If you land on the goals step, check the checkbox that you want to import your content into your site and push the button to continue forward. Retry the step above.
Verify import process still works well.

Pre-merge Checklist

Has the general commit checklist been followed? (PCYsg-hS-p2)
Have you written new tests for your changes?
Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
Have you checked for TypeScript, React or other console errors?
Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

github-actions · 2023-03-14T13:11:10Z

Calypso Live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-60160

Jetpack Cloud live (direct link)

	https://calypso.live?image=registry.a8c.com/calypso/app:build-60160&env=jetpack

matticbot · 2023-03-14T13:22:30Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~324 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper      -1028 B  (-0.0%)     -324 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~109 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
site-setup-flow      +1203 B  (+0.1%)     +430 B  (+0.1%)
sites-dashboard      -1028 B  (-0.2%)     -321 B  (-0.2%)
settings             -1028 B  (-0.1%)     -321 B  (-0.1%)
hosting              -1028 B  (-0.1%)     -321 B  (-0.1%)
home                 -1028 B  (-0.1%)     -321 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~321 bytes removed 📉 [gzipped])

name               parsed_size           gzip_size
async-load-design      -1028 B  (-0.0%)     -321 B  (-0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

flootr

Appears to be working well 🚀

noahtallen · 2023-03-14T19:25:02Z

client/landing/stepper/stores.ts

@@ -26,4 +26,4 @@ export const USER_STORE = User.register( {

 export const AUTOMATED_ELIGIBILITY_STORE = AutomatedTransferEligibility.register();

-export const ANALYZER_STORE = Analyzer.register();
+export const ANALYZER_STORE = Analyzer.store;


General thought for all Automattic data stores -- instead of this, should we just export the store object as Analyzer?

Then, when we're using anything in automattic/data-stores, it becomes simpler to use:

// or export it as analyzerStore, which is a bit clearer and follows our naming conventions import { Analyzer } from '@automattic/data-stires'; useSelect( select => select( Analyzer ) )

(potentially avoiding the need to re-export the store from client/landing/stepper/stores too)

I think for some stores we export additional modules and types, so it might be necessary to export some more on top of the store. For example:

wp-calypso/packages/data-stores/src/onboard/index.ts

Lines 13 to 15 in 9651d4a

export { SiteGoal, SiteIntent } from './constants';

export * as utils from './utils';

export * from './types';

Those are then re-exported by the @automattic/data-stores package and reused somewhere.

I'd suggest approaching those in another PR, since they might require additional work, and I don't see that as something related to refactoring to createReduxStore().

I've removed the store export indirection in 1ce6df9

Fair enough! 👍

bogiii

Looks good to me! 🚢

Data Stores: Migrate Analyzer to createReduxStore()

456ca72

tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Import Stepper Data-Store Light Importer labels Mar 14, 2023

tyxla requested review from bogiii and a team March 14, 2023 13:10

tyxla self-assigned this Mar 14, 2023

tyxla mentioned this pull request Mar 14, 2023

Task: Migrate wp-data stores from registerStore to createReduxStore #74399

Open

40 tasks

flootr approved these changes Mar 14, 2023

View reviewed changes

noahtallen reviewed Mar 14, 2023

View reviewed changes

noahtallen mentioned this pull request Mar 14, 2023

Data Stores: Migrate I18n to createReduxStore() #74427

Merged

7 tasks

Remove unnecessary indirection

1ce6df9

bogiii approved these changes Mar 15, 2023

View reviewed changes

tyxla merged commit 92730aa into trunk Mar 15, 2023

tyxla deleted the migrate/analyzer-store-create-redux-store branch March 15, 2023 11:18

github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 15, 2023

tyxla mentioned this pull request Mar 15, 2023

Data Stores: migrate Subscriber store to createReduxStore #74430

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data Stores: Migrate Analyzer store to `createReduxStore()` #74414

Data Stores: Migrate Analyzer store to `createReduxStore()` #74414

tyxla commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited by matticbot

Loading

matticbot commented Mar 14, 2023 •

edited

Loading

flootr left a comment

noahtallen Mar 14, 2023 •

edited

Loading

tyxla Mar 15, 2023

tyxla Mar 15, 2023

noahtallen Mar 15, 2023

bogiii left a comment

	export { SiteGoal, SiteIntent } from './constants';
	export * as utils from './utils';
	export * from './types';

Data Stores: Migrate Analyzer store to createReduxStore() #74414

Data Stores: Migrate Analyzer store to createReduxStore() #74414

Conversation

tyxla commented Mar 14, 2023 • edited Loading

Proposed Changes

Testing Instructions

Pre-merge Checklist

github-actions bot commented Mar 14, 2023 • edited by matticbot Loading

matticbot commented Mar 14, 2023 • edited Loading

flootr left a comment

Choose a reason for hiding this comment

noahtallen Mar 14, 2023 • edited Loading

Choose a reason for hiding this comment

tyxla Mar 15, 2023

Choose a reason for hiding this comment

tyxla Mar 15, 2023

Choose a reason for hiding this comment

noahtallen Mar 15, 2023

Choose a reason for hiding this comment

bogiii left a comment

Choose a reason for hiding this comment

Data Stores: Migrate Analyzer store to `createReduxStore()` #74414

Data Stores: Migrate Analyzer store to `createReduxStore()` #74414

tyxla commented Mar 14, 2023 •

edited

Loading

github-actions bot commented Mar 14, 2023 •

edited by matticbot

Loading

matticbot commented Mar 14, 2023 •

edited

Loading

noahtallen Mar 14, 2023 •

edited

Loading